Skip to content

hot reloading fix #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2017
Merged

hot reloading fix #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
400b166
hot reloading fix
szyablitsky Apr 1, 2017
86663e2
revert back yarn.lock and database.yml
szyablitsky Apr 1, 2017
00c2a33
revert back yarn.lock
szyablitsky Apr 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions client/webpack.client.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
// Common client-side webpack configuration used by webpack.hot.config and webpack.rails.config.
const webpack = require('webpack');
const path = require('path');
const autoprefixer = require('autoprefixer');

const devBuild = process.env.NODE_ENV !== 'production';
const nodeEnv = devBuild ? 'development' : 'production';
Expand Down Expand Up @@ -77,18 +76,6 @@ module.exports = {
minChunks: Infinity,

}),

new webpack.LoaderOptionsPlugin({
options: {
// Place here all postCSS plugins here, so postcss-loader will apply them
postcss: [autoprefixer],
// Place here all SASS files with variables, mixins etc.
// And sass-resources-loader will load them in every CSS Module (SASS file) for you
// (so don't need to @import them explicitly)
// https://github.com/shakacode/sass-resources-loader
sassResources: ['./app/assets/styles/app-variables.scss']
}
})
],

module: {
Expand Down
2 changes: 2 additions & 0 deletions client/webpack.client.rails.hot.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ config.module.rules.push(
{
test: /\.css$/,
use: [
'style-loader',
{
loader: 'css-loader',
options: {
Expand All @@ -75,6 +76,7 @@ config.module.rules.push(
{
test: /\.scss$/,
use: [
'style-loader',
{
loader: 'css-loader',
options: {
Expand Down
6 changes: 0 additions & 6 deletions client/webpack.server.rails.build.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ module.exports = {
'process.env': {
NODE_ENV: JSON.stringify(nodeEnv),
},
}),
new webpack.LoaderOptionsPlugin({
options: {
sassResources: ['./app/assets/styles/app-variables.scss'],
}
})
],
module: {
Expand Down Expand Up @@ -75,7 +70,6 @@ module.exports = {
loader: 'sass-resources-loader',
options: {
resources: './app/assets/styles/app-variables.scss',
context: __dirname,
},
}
],
Expand Down