WIP Update to React On Rails v6 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
force-pushed
the
update-to-ror-6
branch
from
5aa6dfb
to
c016363
Compare
justin808
force-pushed
the
update-to-ror-6
branch
3 times, most recently
from
680b9a0
to
245d46b
Compare
| @@ -1,30 +0,0 @@ | |||
| # lib/tasks/assets.rake | |||
There was a problem hiding this comment.
UPGRADE NOTE: Note, we removed this WHOLE file!
justin808
force-pushed
the
update-to-ror-6
branch
from
245d46b
to
ccdeaea
Compare
| @@ -33,6 +33,8 @@ | |||
| "build:dev:client": "webpack -w --config webpack.client.rails.build.config.js", | |||
| "build:dev:server": "webpack -w --config webpack.server.rails.build.config.js", | |||
| "build:server": "webpack --config webpack.server.rails.build.config.js", | |||
| "build:test": "npm run build:client && npm run build:server", | |||
| "build:production": "npm run build:production:client && npm run build:production:server", | |||
There was a problem hiding this comment.
UPGRADE NOTE: Be sure to create 2 npm tasks like this. The first one, build:test is for building the assets for running tests. The second one build:production if for building assets before the precompile step. This MUST correspond to your config/initializers/react_on_rails.rb.
justin808
force-pushed
the
update-to-ror-6
branch
2 times, most recently
from
041bbee
to
f4935d1
Compare
justin808
force-pushed
the
update-to-ror-6
branch
from
f4935d1
to
a6bc75c
Compare
* update travis to ruby 2.3.1
justin808
force-pushed
the
update-to-ror-6
branch
from
a6bc75c
to
26bae33
Compare
| "version": "3.0.4", | ||
| "from": "acorn@>=3.0.4 <4.0.0", | ||
| "resolved": "https://registry.npmjs.org/acorn/-/acorn-3.0.4.tgz" | ||
| "version": "3.1.0", |
There was a problem hiding this comment.
UPGRADE NOTE: Do not worry about the diffs in this file. You will update this when you run npm i and maybe npm shrinkwrap. You will probably rm -rf node_modules. All those commands are to be run from the /client dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an example of updating from 5.2 to 6.0 of React on Rails.
This change is