Stop infinitely retrying on network errors for VOD #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not infinitely retry on top of the retry-policy already defined by RetryParameters, especially for VOD. For live video the previous retry logic is still useful to be robust against clock-sync or asset availability issues. This commit adds a boolean configuration parameter, infiniteRetriesForLiveStreams, to allow the user to turn this behavior off even for live video. Fixes shaka-project#830 and shaka-project#762
joeyparrish
approved these changes
Jun 5, 2017
TheModMaker
approved these changes
Jun 5, 2017
|
All tests passed! |
joeyparrish
pushed a commit
that referenced
this pull request
Jun 5, 2017
Do not infinitely retry on top of the retry-policy already defined by RetryParameters, especially for VOD. For live video the previous retry logic is still useful to be robust against clock-sync or asset availability issues. This commit adds a boolean configuration parameter, infiniteRetriesForLiveStreams, to allow the user to turn this behavior off even for live video. Fixes #830 and #762
|
Cherry-picked to v2.1.3. |
bhh1988
added a commit
to box/box-content-preview
that referenced
this pull request
Jun 6, 2017
This is effectively is an upgrade to 2.1.2 with a fix cherry-picked on top: shaka-project/shaka-player#842. This fixes an issue where 401s would get infinitely retried. In addition, the viewer will bind to error-events thrown from shaka-player and propagate it so that the preview fails faster on error
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not infinitely retry on top of the retry-policy already defined by
RetryParameters, especially for VOD. For live video the previous retry
logic is still useful to be robust against clock-sync or asset
availability issues. This commit adds a boolean configuration parameter,
infiniteRetriesForLiveStreams, to allow the user to turn this behavior
off even for live video.
Fixes #830 and #762