Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(Ads): Only create the listeners/timers when there are interstitials #8113

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Feb 19, 2025

No description provided.

@avelad avelad added type: performance A performance issue component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release labels Feb 19, 2025
@avelad avelad added this to the v4.14 milestone Feb 19, 2025
@avelad
Copy link
Member Author

avelad commented Feb 19, 2025

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=8113

@shaka-bot
Copy link
Collaborator

shaka-bot commented Feb 19, 2025

Incremental code coverage: 97.59%

@avelad avelad requested a review from tykus160 February 19, 2025 13:40
@avelad avelad merged commit cbcb1d8 into shaka-project:main Feb 19, 2025
16 of 17 checks passed
@avelad avelad deleted the perf-ads branch February 19, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release type: performance A performance issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants