chore: Simplify Apple detection #8035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tykus160
added
type: code health
avelad
reviewed
Feb 7, 2025
Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
avelad
approved these changes
Feb 7, 2025
|
Incremental code coverage: 96.67% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Apple device detection misdetects any Webkit-based STB as Apple, due to looking only at vendor property. To mitigate it, we were excluding another user agents, but maintenance of this is problematic.
This PR tries to change direction - an Apple device right now is a device with Apple vendor AND with characteristics of MacOS or iOS.