Pull request for issue #780 - Support for VDMS Streams in demo app #781
Conversation
license proxy servers. Add two test assets that use these license proxies. The first is simple single period test asset. The 2nd is a multi period asset that is interspersed with unencrypted ad periods.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
The corporate CLA has been signed according to my knowledge, but it was initiated by Kris Varro in March. I believe our corporate CLA should have been signed and accepted as of March 19th. |
|
@TheJohnBowers, I can see that there is a corporate CLA on file for Verizon Digital Media Services. So the CLA bot must be mistaken. I will report this to the maintainers of that bot and we can proceed. |
|
The CLA bot maintainers have informed me that you need to get yourself added to a group that associates you with the corporate CLA. The maintainer of the group at Verizon Digital Media Services is Daniel Sanders. When you have been added, just comment on the PR and the bot will re-check the group. |
|
Ok, I believe I have been added to the corporate CLA now. |
|
CLAs look good, thanks! |
demo/assets.js
Outdated
| @@ -1097,6 +1141,46 @@ shakaAssets.testAssets = [ | |||
| shakaAssets.Feature.MP4, | |||
| shakaAssets.Feature.SEGMENT_TEMPLATE_DURATION | |||
| ] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Please enclose these assets in their own group. For example, see line 1038 above, where we start a group for GPAC-sourced assets.
demo/assets.js
Outdated
|
|
||
| source: shakaAssets.Source.UPLYNK, | ||
| drm: [ | ||
| shakaAssets.KeySystem.WIDEVINE |
There was a problem hiding this comment.
Add shakaAssets.KeySystem.CLEAR_KEY to this list, as well. Same below.
demo/assets.js
Outdated
| name: 'Big Buck Bunny', | ||
| manifestUri: 'https://content.uplynk.com/224ac8717e714b68831997ab6cea4015.mpd', // gjslint: disable=110 | ||
|
|
||
| source: shakaAssets.Source.UPLYNK, |
There was a problem hiding this comment.
Please specify which encoder was used in the encoder field.
There was a problem hiding this comment.
Done -- Added the "UPLYNK" encoder so I could specify that in these assets.
demo/assets.js
Outdated
| ], | ||
| features: [ | ||
| shakaAssets.Feature.MP4, | ||
| shakaAssets.Feature.SEGMENT_LIST_DURATION |
There was a problem hiding this comment.
Please add Feature.PSSH, Feature.HIGH_DEFINITION.
demo/assets.js
Outdated
| ], | ||
| features: [ | ||
| shakaAssets.Feature.MP4, | ||
| shakaAssets.Feature.SEGMENT_LIST_DURATION |
There was a problem hiding this comment.
Please add Feature.PSSH, Feature.HIGH_DEFINITION, Feature.MULTIPERIOD.
There was a problem hiding this comment.
Done -- I also added shakaAssets.Feature.MULTIPLE_LANGUAGES as I was reviewing the features. This asset has a second Portuguese audio track. We could add a new feature for assets like this that have completely clear periods interspersed with encrypted periods too. I believe you haven't had many tests like this up to this point because of Chrome's issues supporting it until 58.
Add KeySystem.CLEAR_KEY to VDMS assets Update VDMS assets to have an encoder Update VDMS assets to list all relevant features
|
Testing in progress... |
|
All tests passed! |
|
Testing in progress... |
|
All tests passed! |
|
Thanks! |
Closes #780 Backported to v2.0.x
|
Cherry-picked to v2.1.1 and v2.0.9. |
github-actions
bot
added
the
status: archived
I have added a response filter for VDMS manifest responses, as well as a license request filter for VDMS license requests. I then add a couple of test assets that utilize these filters and point to the VDMS widevine and clearkey license proxies.