Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow streaming again when we reset MSE #7495

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: Allow streaming again when we reset MSE #7495

merged 1 commit into from
Oct 24, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Oct 24, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release browser: Safari Issues affecting Safari or WebKit derivatives labels Oct 24, 2024
@avelad avelad added this to the v4.12 milestone Oct 24, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 33.33%

joeyparrish
joeyparrish approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do we want to keep those info logs? Or maybe downgrade them to debug logs?

@avelad
Copy link
Member Author

avelad commented Oct 24, 2024

LGTM, but do we want to keep those info logs? Or maybe downgrade them to debug logs?

It is a log that appears rarely, for me info is perfect

@avelad avelad merged commit bc90c87 into shaka-project:main Oct 24, 2024
21 of 22 checks passed
@avelad avelad deleted the reset-allow-streaming branch October 24, 2024 18:33
@shaka-bot shaka-bot mentioned this pull request Oct 24, 2024
Merged
avelad added a commit that referenced this pull request Oct 24, 2024
@avelad
fix: Allow streaming again when we reset MSE (#7495)
7ba1ee7
@shaka-bot shaka-bot mentioned this pull request Oct 24, 2024
Merged
avelad added a commit that referenced this pull request Oct 24, 2024
@avelad
fix: Allow streaming again when we reset MSE (#7495)
8d2ca38
@shaka-bot shaka-bot mentioned this pull request Oct 24, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Nov 12, 2024
@avelad @joeyparrish
fix: Allow streaming again when we reset MSE (#7495)
23a8ea9
@shaka-bot shaka-bot mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@tykus160 tykus160 Awaiting requested review from tykus160

Assignees
No one assigned
Labels
browser: Safari Issues affecting Safari or WebKit derivatives priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.12
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @joeyparrish