Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): Clone EventStream nodes to reduce memory consumption #7285

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix(DASH): Clone EventStream nodes to reduce memory consumption #7285

merged 1 commit into from
Sep 11, 2024

Conversation

tykus160
Copy link
Member

@tykus160 tykus160 commented Sep 11, 2024 •
edited
Loading

Fixes #7148

@avelad avelad added type: bug Something isn't working correctly type: performance A performance issue component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Sep 11, 2024
@avelad avelad added this to the v4.11 milestone Sep 11, 2024
@avelad avelad merged commit 0023acc into shaka-project:main Sep 11, 2024
21 of 22 checks passed
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@shaka-bot shaka-bot mentioned this pull request Sep 11, 2024
Merged
avelad pushed a commit that referenced this pull request Sep 11, 2024
@tykus160 @avelad
fix(DASH): Clone EventStream nodes to reduce memory consumption (#7285)
d1351bf 
Fixes #7148
@shaka-bot shaka-bot mentioned this pull request Sep 11, 2024
Merged
avelad pushed a commit that referenced this pull request Sep 11, 2024
@tykus160 @avelad
fix(DASH): Clone EventStream nodes to reduce memory consumption (#7285)
edd232b 
Fixes #7148
@shaka-bot shaka-bot mentioned this pull request Sep 11, 2024
Merged
@tykus160 tykus160 deleted the wt-eventnode-clone branch September 11, 2024 15:48
@avelad avelad modified the milestones: v4.11, v4.12 Sep 12, 2024
joeyparrish pushed a commit that referenced this pull request Sep 13, 2024
@tykus160 @joeyparrish
fix(DASH): Clone EventStream nodes to reduce memory consumption (#7285)
4b7d45a 
Fixes #7148
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 10, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly type: performance A performance issue
Projects
None yet
Milestone
v4.12
Development

Successfully merging this pull request may close these issues.

Excessive memory usage for DASH live with EventStream nodes
3 participants
@tykus160 @shaka-bot @avelad