Fix dispose of ad manager on detach #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theodab can you review? |
theodab
requested changes
Sep 28, 2021
theodab
approved these changes
Sep 28, 2021
|
All tests passed! |
joeyparrish
pushed a commit
that referenced
this pull request
Oct 12, 2021
joeyparrish
pushed a commit
that referenced
this pull request
Oct 12, 2021
joeyparrish
pushed a commit
that referenced
this pull request
Oct 12, 2021
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: 7b2a172
The previous commit, when using the
detachfunction,this.adManager_is destroyed and there is nowhere where it will be recreated. But this is not necessary, only with the call toreleasethe dependencies of the video are eliminated, and the object is reusable.