Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Control panel alignment #3650

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

nbcl
Copy link
Contributor

@nbcl nbcl commented Sep 20, 2021

The present pull request aims to provide a solution to a minor visual bug present in the control panel displaying unaligned "sub-menu" buttons (i.e: quality, language, playback_rate).

In the following example, the green and orange rectangles are exactly the same size and dimensions for both images. Note how the alignment of both rectangles and the size of the red areas change between the before (top) and after (bottom) images.

Example

How to preview

Initialize the client with a config that contains sub-menu buttons (i.e: quality, language, playback_rate) and control panel buttons (i.e: fast_forward, fullscreen, overflow_menu) in the controlPanelElements.

const config = {
 'controlPanelElements': ['quality', 'loop', 'fast_forward', 'language', 
                          'playback_rate', 'fullscreen', 'overflow_menu'],
}
ui.configure(config);

Changelog

ui/less/containers.less

Fixes the line-height of elements inside of the control panel, which specifically adjusts the vertical alignment of "sub-menu" buttons.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made the corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

Fixes the alignment of buttons inside the control panel.
@michellezhuogg michellezhuogg merged commit c55ce6c into shaka-project:master Sep 27, 2021
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
Fixes the alignment of buttons inside the control panel.
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
Fixes the alignment of buttons inside the control panel.
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
Fixes the alignment of buttons inside the control panel.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants