Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check KEYID format in lowercase #2790

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Check KEYID format in lowercase #2790

merged 2 commits into from
Aug 24, 2020

Conversation

chrisfillmore
Copy link
Contributor

Closes #2789

@shaka-bot
Copy link
Collaborator

Test Failure:

Generating Closure dependencies...
Linting JavaScript...

/var/lib/jenkins/workspace/Manual PR Test (local-tests)/lib/hls/hls_parser.js
2534:1  error  Line 2534 exceeds the maximum line length of 80  max-len

/var/lib/jenkins/workspace/Manual PR Test (local-tests)/test/hls/hls_parser_unit.js
1724:19  error  Strings must use singlequote  quotes
1724:27  error  Missing semicolon             semi
1748:38  error  Missing semicolon             semi

✖ 4 problems (4 errors, 0 warnings)
3 errors and 0 warnings potentially fixable with the `--fix` option.

END-BUILD: FAILURE
Build step 'Execute shell' marked build as failure

@chrisfillmore chrisfillmore force-pushed the bugfix/keyIdToLowerCase_2789 branch from 2a3203d to e1dd948 Compare August 13, 2020 19:06
@shaka-bot
Copy link
Collaborator

Test Failure:

Generating Closure dependencies...
Linting JavaScript...

/var/lib/jenkins/workspace/Manual PR Test (local-tests)/lib/hls/hls_parser.js
2535:1  error  Expected indentation of 10 spaces but found 8  indent

✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the `--fix` option.

END-BUILD: FAILURE
Build step 'Execute shell' marked build as failure

@joeyparrish
Copy link
Member

You can run ./build/check.py locally to run the linter, and you can run ./build/test.py to run the tests. Thanks!

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Aug 21, 2020
@joeyparrish
Copy link
Member

Just realized I can push an edit into your branch and fix the linter error. I'm re-running the tests now.

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit da74965 into shaka-project:master Aug 24, 2020
joeyparrish pushed a commit that referenced this pull request Aug 25, 2020
@chrisfillmore @joeyparrish
fix(DRM): Check KEYID format in lowercase (#2790)
e0a7452 
Closes #2789

Backported to v2.5.x

Change-Id: I60f841d9c4f5c5ac308fc5b1daed442a231310cf
@chrisfillmore
Copy link
Contributor Author

Thanks @joeyparrish!

joeyparrish pushed a commit that referenced this pull request Aug 25, 2020
@chrisfillmore @joeyparrish
fix(DRM): Check KEYID format in lowercase (#2790)
1b2d737 
Closes #2789
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect KEYID format on Widevine protected HLS stream
3 participants
@chrisfillmore @shaka-bot @joeyparrish