-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AirPlay button to overflow menu #2701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also maintain a list of UI buttons in our docs, in ui-customization.md
. You should list this button there.
@theodab @michellezhuogg Is there anything else I can do? Do you need any more changes? |
I updated the PR with the change of button name |
LGTM. I'll run the build bot on this. |
Test Failure:
|
Test Failure:
|
Hm. I see the same test failure on other CLs that have been tested today, so this isn't your PR's fault. |
Thanks for your contributions! |
Whoops, I added the semantic versioning tag into the commit message, rather than the title. |
Hi! |
Thank you! |
Resolves #1003