Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AirPlay button to overflow menu #2701

Merged
merged 4 commits into from
Jul 14, 2020

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 30, 2020

Resolves #1003

Copy link
Contributor

@michellezhuogg michellezhuogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also maintain a list of UI buttons in our docs, in ui-customization.md. You should list this button there.

ui/locales/en.json Outdated Show resolved Hide resolved
ui/ui.js Outdated Show resolved Hide resolved
@avelad avelad requested review from theodab and michellezhuogg July 8, 2020 06:12
@avelad
Copy link
Member Author

avelad commented Jul 14, 2020

@theodab @michellezhuogg Is there anything else I can do? Do you need any more changes?

@avelad
Copy link
Member Author

avelad commented Jul 14, 2020

I updated the PR with the change of button name

@theodab
Copy link
Contributor

theodab commented Jul 14, 2020

LGTM. I'll run the build bot on this.

@shaka-bot
Copy link
Collaborator

Test Failure:

Generating Closure dependencies...
Linting JavaScript...
Linting CSS...
Linting HTML...

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Scanned 3 files, no errors found (40 ms).
Checking that the build files are complete...
Checking for common misspellings...
Checking correct usage of eslint-disable...
Checking the tests for type errors...
No changes detected, skipping. Use --force to override.
Building the docs...
�[31mSyntaxError: The "url" argument must be of type string. Received type object�[39m�[31m in �[39m/var/lib/jenkins/workspace/Manual PR Test (local-tests)/ui/controls.less�[90m on line 17, column 1:�[39m
�[90m16 // NOTE: Working around google/material-design-icons#958�[39m
17 �[7m�[31m�[1m@�[22mimport (css, inline) "https://fonts.googleapis.com/icon?family=Material+Icons+Round";�[39m�[27m
�[90m18 �[39m�[0m�[0m

Externs generation failed
END-BUILD: FAILURE
Build step 'Execute shell' marked build as failure

@shaka-bot
Copy link
Collaborator

Test Failure:

Generating Closure dependencies...
Linting JavaScript...
Linting CSS...
Linting HTML...

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Scanned 3 files, no errors found (55 ms).
Checking that the build files are complete...
Checking for common misspellings...
Checking correct usage of eslint-disable...
Checking the tests for type errors...
No changes detected, skipping. Use --force to override.
Building the docs...
�[31mSyntaxError: The "url" argument must be of type string. Received type object�[39m�[31m in �[39m/var/lib/jenkins/workspace/Manual PR Test (local-tests)/ui/controls.less�[90m on line 17, column 1:�[39m
�[90m16 // NOTE: Working around google/material-design-icons#958�[39m
17 �[7m�[31m�[1m@�[22mimport (css, inline) "https://fonts.googleapis.com/icon?family=Material+Icons+Round";�[39m�[27m
�[90m18 �[39m�[0m�[0m

Externs generation failed
END-BUILD: FAILURE
Build step 'Execute shell' marked build as failure

@theodab
Copy link
Contributor

theodab commented Jul 14, 2020

Hm. I see the same test failure on other CLs that have been tested today, so this isn't your PR's fault.
I think the MDL people might have messed up the CSS they are hosting, or something like that?
I tried doing a local test run and I didn't see any issues, anyway. I think this is safe.

@theodab theodab merged commit fac2913 into shaka-project:master Jul 14, 2020
@theodab
Copy link
Contributor

theodab commented Jul 14, 2020

Thanks for your contributions!

@theodab
Copy link
Contributor

theodab commented Jul 14, 2020

Whoops, I added the semantic versioning tag into the commit message, rather than the title.

@avelad avelad deleted the airplay-button branch July 15, 2020 05:28
@IvarssonAndreas
Copy link

Hi!
What is the status of this issue?
What I can tell the contribution is merged but not included in any release?

@theodab
Copy link
Contributor

theodab commented Nov 17, 2020

This pull request has been merged into master. You can see it on the commit log: fac2913
It hasn't been put into a release yet. As you can see from the associated issue, #1003, it is currently slated to go into the upcoming v3.1 release.

@IvarssonAndreas
Copy link

Thank you!

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AirPlay
5 participants