Filter metadata textracks in player APIs for src mode #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joeyparrish can you review it? |
joeyparrish
requested changes
Apr 23, 2020
lib/player.js
Outdated
| @@ -2856,7 +2856,7 @@ shaka.Player = class extends shaka.util.FakeEventTarget { | |||
| return tracks; | |||
| } else if (this.video_ && this.video_.src && this.video_.textTracks) { | |||
| const textTracks = Array.from(this.video_.textTracks) | |||
| .filter((t) => t.mode != 'disabled'); | |||
| .filter((t) => t.mode != 'disabled' && t.kind != 'metadata'); | |||
There was a problem hiding this comment.
I'm reverting the change to filter on mode != 'disabled', so this will have to be updated soon. Sorry for the inconvenience, and thanks for the bug reports!
There was a problem hiding this comment.
I've just merged the change I mentioned. Please rebase at your earliest convenience. The rest of the change looks good. Thanks!
There was a problem hiding this comment.
I have done rebase. Thank you.
joeyparrish
approved these changes
Apr 24, 2020
|
All tests passed! |
joeyparrish
pushed a commit
that referenced
this pull request
May 1, 2020
Backported to v2.5.x Resolves #2518 Change-Id: I5f534829a3d56e8067120dfb1750f1d04f27c4ab
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2518