Fix download contents with Widevine and Playready in the manifest. #2400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested changes
Feb 18, 2020
|
@joeyparrish , There are another ticket for tracking tests on manifest wihout init data: #2168 Please, don't block this PR due the previous ticket. I can do the test when the previous ticket closes. |
|
@TheModMaker, could you please review this and consider #2168 when you do? |
TheModMaker
reviewed
Feb 19, 2020
…e, it should be calculated only once.
TheModMaker
approved these changes
Feb 21, 2020
|
All tests passed! |
joeyparrish
pushed a commit
that referenced
this pull request
Mar 12, 2020
…2400) Backported to v2.5.x Change-Id: Ie99dc52e432d3248f3eaf7e2710a3f798482d953
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit c56fe7d introduce a regression in manifest with Playready and Widevine.
The commit doesn't filter initData that are not part of the current DRM selected for download.