Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requestUri as a property on shaka.extern.Response #1972

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Add requestUri as a property on shaka.extern.Response #1972

merged 1 commit into from
Jun 1, 2019

Conversation

chrisfillmore
Copy link
Contributor

This property tracks the original request uri, which would be
useful to know in the event of a redirect.

Issue #1971

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@chrisfillmore
Copy link
Contributor Author

My company email changed... I have updated my profile googlebot

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@chrisfillmore chrisfillmore mentioned this pull request May 31, 2019
Closed
Add originalUri as a property on shaka.extern.Response
8c9741e 
This property tracks the original request uri, which would be
useful to know in the event of a redirect.

Issue shaka-project#1971
@chrisfillmore chrisfillmore force-pushed the feature/requestUri_1971 branch from 6cbc33a to 8c9741e Compare June 1, 2019 15:04
joeyparrish
joeyparrish approved these changes Jun 1, 2019
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit d846e58 into shaka-project:master Jun 1, 2019
@chrisfillmore chrisfillmore deleted the feature/requestUri_1971 branch June 2, 2019 00:05
joeyparrish pushed a commit that referenced this pull request Jun 4, 2019
@chrisfillmore @joeyparrish
Add originalUri as a property on shaka.extern.Response (#1972)
8744190 
This property tracks the original request uri, which would be
useful to know in the event of a redirect.

Fixes #1971

Backported to v2.5.x
AnteWall pushed a commit to AnteWall/shaka-player that referenced this pull request Jul 17, 2019
@chrisfillmore @AnteWall
Add originalUri as a property on shaka.extern.Response (shaka-project…
2aa1676 
…#1972)

This property tracks the original request uri, which would be
useful to know in the event of a redirect.

Fixes shaka-project#1971
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisfillmore @googlebot @shaka-bot @joeyparrish