Skip to content

Explicitly disabling ABR when selecting tracks #962

Closed
@bhh1988

Description

@bhh1988

Looking at the docs here: https://github.com/google/shaka-player/blob/master/docs/tutorials/upgrade-v2-0.md

The example shows calling player.configure() AFTER selectVariantTrack(), to disable ABR. That doesn't seem to work well in practice. It seems better to call player.configure() to disable ABR BEFORE calling selectVariantTrack(). I think either the docs should change to reflect that, or the code should change to reflect the docs - my guess is that the problem is that inside of player.js's applyConfig_() method chooseStreamsAndSwitch_() is called before actually disabling ABR. It seems that most any call to player.configure() will potentially undo a previous selectVariantTrack() call.

I was testing this on HEAD of master about one week ago.

Metadata

Metadata

Assignees

Labels

status: archivedArchived and locked; will not be updatedtype: docsImprovements or fixes to documentation

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions