selectAudioLanguage with a "role" doesn't immediately select correct audio track

[bhh1988]

This bug can be reproduced only if there are audio tracks with the same language, but different roles. Selecting a new audio track is effectively a no-op. Stepping through the code, this is due to a bug in chooseStreams_() in player.js, which only checks for if language has changed between the selected and currently active track, when deciding whether to actually switch tracks or not (it does look like it's setting the correct list of variants for ABR though, since 4012194 for #767 , so I believe ABR would eventually set the desired audio track eventually).

[joeyparrish]

@bhh1988, I believe this may have been fixed in the refactor in 7e0f469. Would you be willing to retest?

[bhh1988]

Yes this seems to be fixed now. Thanks!

[bhh1988]

I realize this issue still exists in 2.1.6. Makes sense because 7e0f469 isn't on that branch yet. Is there a plan to backport the fix? What's the policy for closing issues under these kinds of circumstances?

[joeyparrish]

I can confirm that this is still an issue on the v2.1.x branch. Confirming that was hard and involved a lot of hacks, which led me to file #967 to add roles to the demo app UI.

I need to determine if backporting that refactor to v2.1.x is feasible.