Skip to content

InbandEventStream at Representation level being ignored #686

Closed
@sanbornhilland

Description

@sanbornhilland

Reproducible on master

It appears that <InbandEventStream> elements are being ignored if they are present at the Representation level.

For example these are being ignored (http://demo.yospace.com/quickplay/dash/vod.mpd):

<AdaptationSet contentType="video" par="640:360" minWidth="640" maxWidth="640" minHeight="360" maxHeight="360" mimeType="video/mp4" codecs="avc1.4d401f">
  <Representation id="0" bandwidth="300000" width="640" height="360" sar="1:1" frameRate="30">
    <InbandEventStream schemeIdUri="urn:yospace:a:id3:2016" value="0"/>
    <SegmentTemplate media="ad1/u-6600-b-640x360-300-1-$Number$.mp4" initialization="ad1/u-6600-b-640x360-300-1-i.mp4" startNumber="0" timescale="15360">
      <SegmentTimeline>
        <S d="122880"/>
        <S d="108032"/>
      </SegmentTimeline>
    </SegmentTemplate>
  </Representation>
</AdaptationSet>

The dash_parser only searches the immediate children of the <AdaptationSet>:

var eventStream = XmlUtils.findChild(elem, 'InbandEventStream');
var containsInband = eventStream != null;

In the version of the DASH spec that I have(Second edition 2014-05-15) it says in 5.10.3.2 that:

An inband event stream that is present in a Representation shall be indicated by an InbandEventStream element on Adaptation Set or Representation level.

So I believe the test asset above is correct and Shaka should not be ignoring these.

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: archivedArchived and locked; will not be updated

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions