/build/types/core file is missing in NPM package

[Anonym-tsk]

Have you read the FAQ and checked for duplicate open issues? Yes

What version of Shaka Player are you using? 3.0.1

Can you reproduce the issue with our latest release version? From 2.5.11

Can you reproduce the issue with the latest code from master? No

Are you using the demo app or your own custom app? No

If custom app, can you reproduce the issue using our demo app? No

What browser and OS are you using? Any browser

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What did you do?

I try to build player from NPM
python build/build.py --force +@complete

What did you expect to happen?
Successful build

What actually happened?

I got error
[ERROR] Build file not found: core
It's because /build/types/core is missing in NPM from 2.5.11

in the release on github this file is present

[Anonym-tsk]

It looks like npm bug, because:
npm i -D https://github.com/google/shaka-player/tarball/v3.0.1 works
npm i -D git+https://github.com/google/shaka-player.git#v3.0.1 doesn't
yarn install git+https://github.com/google/shaka-player.git#v3.0.1 works

[joeyparrish]

That's really odd. Perhaps at some point, "core" was added to some ignore-list for NPM or git, on the assumption that it was a Linux core dump. It's not in our .npmignore file, though.

I find that it's present in v2.5.10, but not v2.5.11 or later.

Aha! Yes, that's the cause indeed. This appears to be the issue: npm/npm-packlist#24

This comment suggests a workaround we can use in our repo: npm/npm-packlist#24 (comment)

But I don't think there's any way to re-publish npm packages with the same version once they are out, so the fix will only affect future releases of Shaka Player.

[joeyparrish]

The packages for v2.5.14 and v3.0.2 have the npm workaround. You should see build/types/core in those releases.