Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verbose logging flags for CMake branch #1266

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

cosmin
Copy link
Contributor

@cosmin cosmin commented Sep 25, 2023

No description provided.

@cosmin cosmin changed the title Implement verbose logging feat: add verbose logging flags for CMake branch Sep 26, 2023
@cosmin cosmin marked this pull request as ready for review September 26, 2023 23:33
@cosmin cosmin requested a review from joeyparrish September 26, 2023 23:33
@cosmin cosmin changed the title feat: add verbose logging flags for CMake branch feat!: add verbose logging flags for CMake branch Sep 26, 2023
@joeyparrish joeyparrish changed the title feat!: add verbose logging flags for CMake branch feat: add verbose logging flags for CMake branch Oct 9, 2023
@joeyparrish
Copy link
Member

I fixed the backward compatibility and updated the PR title and description. Let's merge if the tests pass. Thanks!

@joeyparrish joeyparrish merged commit 72117f8 into shaka-project:cmake Oct 9, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Dec 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants