ci: Fix repo settings for self-hosted runners and debugging #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hack of using "secrets" to store per-repo settings was not working. The main reason is that pull_request workflows don't have access to secrets no matter what you do. So it was impossible to make this work for settings like "ENABLE_SELF_HOSTED" for PR tests. This change replaces that old hack with a new one. Now a repo owner must create a "GitHub Environment" with the name of the setting they want to enable. Currently supported values are "self_hosted", to add self-hosted runners to the build/test matrix, and "debug", to start an SSH server for debugging when a workflow fails.
|
Note that because the settings were not working, we did not realize the arm64 build workflow was broken. There will be a follow-up PR with a fix for that. |
theodab
approved these changes
Oct 25, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hack of using "secrets" to store per-repo settings was not working. The main reason is that pull_request workflows don't have access to secrets no matter what you do. So it was impossible to make this work for settings like "ENABLE_SELF_HOSTED" for PR tests.
This change replaces that old hack with a new one. Now a repo owner must create a "GitHub Environment" with the name of the setting they want to enable. Currently supported values are "self_hosted", to add self-hosted runners to the build/test matrix, and "debug", to start an SSH server for debugging when a workflow fails.
Issue #1047 (CMake porting)