Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update URLs after moving projects #1042

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented Mar 3, 2022

Since a project URL is encoded into outputs, this means also updating
the golden output files.

Closes #1043

@joeyparrish joeyparrish requested review from kqyang and theodab March 3, 2022 20:23
theodab
theodab previously approved these changes Mar 3, 2022
@joeyparrish
Copy link
Member Author

I need to fix some linter issues before I can merge this. (I need to figure out how to get clang-format to forgive line lengths if it's a URL.)

Apologies!

Since a project URL is encoded into outputs, this means also updating
the golden output files.
@joeyparrish joeyparrish merged commit f577e2a into shaka-project:main Mar 7, 2022
@joeyparrish joeyparrish deleted the move branch March 7, 2022 22:25
sr1990 pushed a commit to sr1990/shaka-packager that referenced this pull request Feb 18, 2023
Since a project URL is encoded into outputs, this means also updating
the golden output files.

Closes shaka-project#1043
sr1990 pushed a commit to sr1990/shaka-packager that referenced this pull request Feb 18, 2023
Since a project URL is encoded into outputs, this means also updating
the golden output files.

Closes shaka-project#1043
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial and Documentation link inside readme.md not working
2 participants