Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle invalid elements correctly #456

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

alexneufeld
Copy link
Contributor

improves https://forum.freecad.org/viewtopic.php?p=807080#p807996

before:

...
<class 'ValueError'>: invalid literal for int() with base 10: 'e81'
20:36:39  Sheet_Unfold: invalid literal for int() with base 10: 'e81'

after:

...
<class 'ValueError'>: Invalid shape name ?Face81
15:02:43  Sheet_Unfold: Invalid shape name ?Face81

@shaise shaise merged commit 0d2ae27 into shaise:master Feb 2, 2025
@shaise
Copy link
Owner

shaise commented Feb 2, 2025

Thanks!
I have also posted an issue that sheetmetal doen not wotk well with the new TNP mitigation. (although on RT version it works)

@alexneufeld
Copy link
Contributor Author

Thanks! I have also posted an issue that sheetmetal done not wotk well with the new TNP mitigation. (although on RT version it works)

I've also noticed reference tracking failures on 1.1dev (I.E. in the trivial case of updated sheetmetal features with identical edges) I assume either we are doing something wrong here, or some portion of the toponaming python API changes didn't get ported over from RT version. Let me know if you want me to test anything specific 👍

@shaise
Copy link
Owner

shaise commented Feb 2, 2025

Let me know if you want me to test anything specific

This is the issue and the test i used: FreeCAD/FreeCAD#18671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants