Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow unfolding flat shapes #442

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

alexneufeld
Copy link
Contributor

closes #441

@shaise shaise merged commit 4626f12 into shaise:master Jan 14, 2025
@shaise
Copy link
Owner

shaise commented Jan 14, 2025

Thanks!
However, now if you select a side face, you do not get any error. Perhaps it is not that critical.

@alexneufeld
Copy link
Contributor Author

Thanks! However, now if you select a side face, you do not get any error. Perhaps it is not that critical.

not critical, and totally unsolvable in the general case. All you need is one fillet to make a side face look unfoldable:

image

We could replace the root face selection step with a heuristic that selects a root based on something like 'largest-flat-planar-face'. That eliminates the possibility of unfolding 'in-place' though. Every other CAD software I've used works similarly to our current process (user selects a root face to unfold from) so I'm inclined to keep doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewUnfolder, parts without bends do not unfold
2 participants