Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3 fixes #16

Merged
merged 2 commits into from
Jul 22, 2017
Merged

py3 fixes #16

merged 2 commits into from
Jul 22, 2017

Conversation

looooo
Copy link
Contributor

@looooo looooo commented Jul 21, 2017

this one should work now:

the problem was a strange starting character. No idea what it was used for. It isn't listed in the diff, but I think it is removed with the commits.

@easyw
Copy link
Contributor

easyw commented Jul 21, 2017

I think for python != when None is present is suggested to use 'is not'
if the_index != None:
becomes
if the_index is not None:
and the same for i.e.
if the_index == None:
becomes
if the_index is None:
Maurice

@looooo
Copy link
Contributor Author

looooo commented Jul 21, 2017

<> is replaced with !=. So I would go with this syntax as it doesn't change the behavior.

@shaise
Copy link
Owner

shaise commented Jul 22, 2017

Thanks looooo, '<>' is indeed now obsolete. merging pull request.

@shaise shaise closed this Jul 22, 2017
@shaise shaise reopened this Jul 22, 2017
@shaise shaise merged commit 4db5840 into shaise:master Jul 22, 2017
@looooo
Copy link
Contributor Author

looooo commented Jul 23, 2017

thanks

shaise pushed a commit that referenced this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants