forked from sourcenetwork/defradb
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PR(ACP): Disable Mutation Of Policy Through Patch
- Loading branch information
1 parent
644acc2
commit b2cd5e1
Showing
4 changed files
with
193 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
tests/integration/collection_description/updates/remove/policy_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
// Copyright 2024 Democratized Data Foundation | ||
// | ||
// Use of this software is governed by the Business Source License | ||
// included in the file licenses/BSL.txt. | ||
// | ||
// As of the Change Date specified in that file, in accordance with | ||
// the Business Source License, use of this software will be governed | ||
// by the Apache License, Version 2.0, included in the file | ||
// licenses/APL.txt. | ||
|
||
package remove | ||
|
||
import ( | ||
"testing" | ||
|
||
testUtils "github.com/sourcenetwork/defradb/tests/integration" | ||
acpUtils "github.com/sourcenetwork/defradb/tests/integration/acp" | ||
) | ||
|
||
func TestColDescrUpdateRemovePolicy_Errors(t *testing.T) { | ||
test := testUtils.TestCase{ | ||
Actions: []any{ | ||
testUtils.AddPolicy{ | ||
|
||
Creator: acpUtils.Actor1Signature, | ||
|
||
Policy: ` | ||
description: a test policy which marks a collection in a database as a resource | ||
actor: | ||
name: actor | ||
resources: | ||
users: | ||
permissions: | ||
read: | ||
expr: owner + reader | ||
write: | ||
expr: owner | ||
relations: | ||
owner: | ||
types: | ||
- actor | ||
reader: | ||
types: | ||
- actor | ||
admin: | ||
manages: | ||
- reader | ||
types: | ||
- actor | ||
`, | ||
|
||
ExpectedPolicyID: "53980e762616fcffbe76307995895e862f87ef3f21d509325d1dc772a770b001", | ||
}, | ||
|
||
testUtils.SchemaUpdate{ | ||
Schema: ` | ||
type Users @policy( | ||
id: "53980e762616fcffbe76307995895e862f87ef3f21d509325d1dc772a770b001", | ||
resource: "users" | ||
) { | ||
name: String | ||
age: Int | ||
} | ||
`, | ||
}, | ||
|
||
testUtils.PatchCollection{ | ||
Patch: ` | ||
[ | ||
{ "op": "remove", "path": "/1/Policy" } | ||
] | ||
`, | ||
ExpectedError: "collection policy cannot be mutated. CollectionID: 1", | ||
}, | ||
}, | ||
} | ||
|
||
testUtils.ExecuteTestCase(t, test) | ||
} |
83 changes: 83 additions & 0 deletions
83
tests/integration/collection_description/updates/replace/policy_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
// Copyright 2024 Democratized Data Foundation | ||
// | ||
// Use of this software is governed by the Business Source License | ||
// included in the file licenses/BSL.txt. | ||
// | ||
// As of the Change Date specified in that file, in accordance with | ||
// the Business Source License, use of this software will be governed | ||
// by the Apache License, Version 2.0, included in the file | ||
// licenses/APL.txt. | ||
|
||
package replace | ||
|
||
import ( | ||
"testing" | ||
|
||
testUtils "github.com/sourcenetwork/defradb/tests/integration" | ||
) | ||
|
||
func TestColDescrUpdateReplacePolicy_Errors(t *testing.T) { | ||
test := testUtils.TestCase{ | ||
Actions: []any{ | ||
testUtils.SchemaUpdate{ | ||
Schema: ` | ||
type Users {} | ||
`, | ||
}, | ||
testUtils.PatchCollection{ | ||
Patch: ` | ||
[ | ||
{ "op": "replace", "path": "/1/Policy", "value": {} } | ||
] | ||
`, | ||
ExpectedError: "collection policy cannot be mutated. CollectionID: 1", | ||
}, | ||
}, | ||
} | ||
|
||
testUtils.ExecuteTestCase(t, test) | ||
} | ||
|
||
func TestColDescrUpdateReplacePolicyID_Errors(t *testing.T) { | ||
test := testUtils.TestCase{ | ||
Actions: []any{ | ||
testUtils.SchemaUpdate{ | ||
Schema: ` | ||
type Users {} | ||
`, | ||
}, | ||
testUtils.PatchCollection{ | ||
Patch: ` | ||
[ | ||
{ "op": "replace", "path": "/1/Policy", "value": {"ID": "dfe202ffb4f0fe9b46157c313213a383"} } | ||
] | ||
`, | ||
ExpectedError: "collection policy cannot be mutated. CollectionID: 1", | ||
}, | ||
}, | ||
} | ||
|
||
testUtils.ExecuteTestCase(t, test) | ||
} | ||
|
||
func TestColDescrUpdateReplacePolicyResource_Errors(t *testing.T) { | ||
test := testUtils.TestCase{ | ||
Actions: []any{ | ||
testUtils.SchemaUpdate{ | ||
Schema: ` | ||
type Users {} | ||
`, | ||
}, | ||
testUtils.PatchCollection{ | ||
Patch: ` | ||
[ | ||
{ "op": "replace", "path": "/1/Policy", "value": {"ResourceName": "mutatingResource"} } | ||
] | ||
`, | ||
ExpectedError: "collection policy cannot be mutated. CollectionID: 1", | ||
}, | ||
}, | ||
} | ||
|
||
testUtils.ExecuteTestCase(t, test) | ||
} |