Pass integer value to FFMPEG for trimming (#89)#126
Merged
Conversation
Owner
|
Hi @gvillenave ! Thank you for this PR. Ca you please explain why your changes need to be merged ? |
Contributor
Author
|
It’s a fix for the bug described in #89
…________________________________
From: Shahen Hovhannisyan <notifications@github.com>
Sent: Monday, October 23, 2017 7:24:58 AM
To: shahen94/react-native-video-processing
Cc: Gabriel Villenave; Mention
Subject: Re: [shahen94/react-native-video-processing] Pass integer value to FFMPEG for trimming (#89) (#126)
Hi @gvillenave<https://github.com/gvillenave> ! Thank you for this PR.
Ca you please explain why your changes need to be merged ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#126 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAjMdvCRsae4zcOaIcSEMnFWEPGUUyx8ks5svKG5gaJpZM4QC6-W>.
|
Owner
|
Aahhh, got it - Thanks @gvillenave ! |
Owner
|
@gvillenave merged and published to npm |
Contributor
Author
|
Thanks for the quick merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.