Skip to content

fix trim accuracy #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahen94 merged 1 commit into from
Sep 24, 2017
Merged

fix trim accuracy #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions android/src/main/java/com/shahenlibrary/Trimmer/Trimmer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,16 +562,22 @@ static void crop(String source, ReadableMap options, final Promise promise, Reac
ArrayList<String> cmd = new ArrayList<String>();
cmd.add("-y"); // NOTE: OVERWRITE OUTPUT FILE

// NOTE: INPUT FILE
cmd.add("-i");
cmd.add(source);

// NOTE: PLACE ARGUMENTS FOR FFMPEG IN THIS ORDER:
// 1. "-i" (INPUT FILE)
// 2. "-ss" (START TIME)
// 3. "-to" (END TIME) or "-t" (TRIM TIME)
// OTHERWISE WE WILL LOSE ACCURACY AND WILL GET WRONG CLIPPED VIDEO

String startTime = options.getString("startTime");
if ( !startTime.equals(null) && !startTime.equals("") ) {
cmd.add("-ss");
cmd.add(startTime);
}

// NOTE: INPUT FILE
cmd.add("-i");
cmd.add(source);

String endTime = options.getString("endTime");
if ( !endTime.equals(null) && !endTime.equals("") ) {
cmd.add("-to");
Expand Down