Create Flow definition file for Lexical core (facebook#1350)

shahboz100 · Apr 9, 2022 · 993a2ea · 993a2ea
1 parent 198611d
commit 993a2ea
Show file tree

Hide file tree

Showing 13 changed files with 1,016 additions and 122 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -2,6 +2,7 @@
 
 packages/**/dist/*.js
 packages/**/config/*.js
+packages/**/*.js.flow
 packages/playwright
 packages/playwright-core
 packages/babel-plugin-transform-stylex

diff --git a/.flowconfig b/.flowconfig
@@ -16,8 +16,6 @@ untyped-type-import=error
 server.max_workers=4
 exact_by_default=true
 
-module.name_mapper='^lexical$' -> '<PROJECT_ROOT>/packages/lexical/src/index.js'
-
 module.name_mapper='^lexical/HeadingNode' -> '<PROJECT_ROOT>/packages/lexical/src/nodes/extended/LexicalHeadingNode.js'
 module.name_mapper='^lexical/QuoteNode' -> '<PROJECT_ROOT>/packages/lexical/src/nodes/extended/LexicalQuoteNode.js'
 module.name_mapper='^lexical/CodeNode' -> '<PROJECT_ROOT>/packages/lexical/src/nodes/extended/LexicalCodeNode.js'
@@ -82,7 +80,6 @@ module.name_mapper='^@lexical/yjs$' -> '<PROJECT_ROOT>/packages/lexical-yjs/src/
 
 module.name_mapper='^shared/invariant' -> '<PROJECT_ROOT>/packages/shared/src/invariant.js'
 module.name_mapper='^shared/environment' -> '<PROJECT_ROOT>/packages/shared/src/environment.js'
-module.name_mapper='^shared/getPossibleDecoratorNode' -> '<PROJECT_ROOT>/packages/shared/src/getPossibleDecoratorNode.js'
 module.name_mapper='^shared/useLayoutEffect' -> '<PROJECT_ROOT>/packages/shared/src/useLayoutEffect.js'
 module.name_mapper='^shared/canUseDOM' -> '<PROJECT_ROOT>/packages/shared/src/canUseDOM.js'
 

diff --git a/jest.config.js b/jest.config.js
@@ -86,8 +86,6 @@ module.exports = {
           '<rootDir>/packages/lexical/src/nodes/extended/LexicalQuoteNode.js',
         '^shared/canUseDOM$': '<rootDir>/packages/shared/src/canUseDOM.js',
         '^shared/environment$': '<rootDir>/packages/shared/src/environment.js',
-        '^shared/getPossibleDecoratorNode$':
-          '<rootDir>/packages/shared/src/getPossibleDecoratorNode.js',
         '^shared/invariant$': '<rootDir>/packages/shared/src/invariant.js',
         '^shared/useLayoutEffect$':
           '<rootDir>/packages/shared/src/useLayoutEffect.js',

diff --git a/packages/lexical-helpers/src/LexicalEventHelpers.js b/packages/lexical-helpers/src/LexicalEventHelpers.js
@@ -22,14 +22,13 @@ import {$cloneContents} from '@lexical/helpers/selection';
 import {
   $createNodeFromParse,
   $createParagraphNode,
+  $getDecoratorNode,
   $getSelection,
   $isDecoratorNode,
   $isElementNode,
   $isRangeSelection,
 } from 'lexical';
 
-import getPossibleDecoratorNode from '../../shared/src/getPossibleDecoratorNode';
-
 // TODO the Flow types here needs fixing
 export type EventHandler = (
   // $FlowFixMe: not sure how to handle this generic properly
@@ -216,7 +215,7 @@ export function $shouldOverrideDefaultCharacterSelection(
   selection: RangeSelection,
   isBackward: boolean,
 ): boolean {
-  const possibleNode = getPossibleDecoratorNode(selection.focus, isBackward);
+  const possibleNode = $getDecoratorNode(selection.focus, isBackward);
   return $isDecoratorNode(possibleNode) && !possibleNode.isIsolated();
 }