Skip to content

Add initial value selection #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2016
Merged

Add initial value selection #2

merged 2 commits into from
Mar 22, 2016

Conversation

T1T4N
Copy link

@T1T4N T1T4N commented Mar 21, 2016

Include newest version of jQuery in folder
Add example page
Add modified jQuery knob script

codemill-id-56e13fc81dc4dd0300fe926d fixes #1

Include newest version of jQuery in folder
Add example page
@shaharsol
Copy link
Owner

@T1T4N thanks for the PR! two comments:

  1. When I run the example, after I click the 1st click (to mark the initialAngel), let's say I click at around 180 degrees, the right side of the knob (0-180 degrees) is getting white. I assume it was meant to mark the point I clicked, but I think there can be a more usable way to mark that, maybe a thin line at about where I clicked?
  2. I'm not sure how to query the knob for the initialAngle and the "length of arc" values. can you add to the example a button that upon click alerts the two values so I can understand how to access them from the containing page?

Add test button showing values
@T1T4N
Copy link
Author

T1T4N commented Mar 22, 2016

@shaharsol Hello,
I modified the code so the degrees from 0 to the selected initial angle don't get hidden (my logic behind this was to prevent the user from inserting negative angles)
I also added an example button "Show values" that displays our current initial angle and the changed value.
Since there is no direct interface to the knob's internal values, I've added a code that copies the values in our own variables when the 'release' event is triggered.

shaharsol added a commit that referenced this pull request Mar 22, 2016
Add initial value selection
@shaharsol shaharsol merged commit 53e7f43 into shaharsol:master Mar 22, 2016
@shaharsol
Copy link
Owner

@T1T4N Thanks Robert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a range input
2 participants