Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recompiler: add use tracking #1431

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

baggins183
Copy link
Contributor

Add use tracking for instructions

Still want to add iterator adaptor for (distinct) users in addition to uses.

@baggins183
Copy link
Contributor Author

on previous commit I stored uses (inst, index) in a list and used an adaptor to iterate over users.
That was broken though because apparently std:: or boost::unique modify the underlying container.
I changed it so per Inst, users are stored in a list, and nodes in the list hold a user + bitmask of the arg indices that use *this.
Needs a lot more lines of code. I wonder if there's to fix the old way so its simpler.

Still needs boost submodule update

@georgemoralis
Copy link
Collaborator

i don't see a pr for it on https://github.com/shadps4-emu/ext-boost :/

@georgemoralis
Copy link
Collaborator

@baggins183 if you can pr on boost the neccesary change so we can progress with that pr too

@baggins183
Copy link
Contributor Author

@georgemoralis here u go boss
shadps4-emu/ext-boost#9

@georgemoralis
Copy link
Collaborator

merge you need to update submodule here so we can see if it builds ;D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants