Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better screenshots for 0.3.0 #1040

Closed
wants to merge 2 commits into from
Closed

Conversation

Xphalnos
Copy link
Contributor

@polybiusproxy 0.3.0 is released!
I removed the "Sister Projects" part because it already exists in "Special Thanks".

Before:
Before

After:
After

@raphaelthegreat
Copy link
Collaborator

I think in-game screenshots might be better

@Xphalnos
Copy link
Contributor Author

Can someone send me ingame screenshots of Bloodborne, Resident Evil 4, Red Dead Redemption and Dark Souls. (They all crash after the menu on my Intel Integrated Graphics)

@polybiusproxy
Copy link
Collaborator

I agree, in-game screenies would be better.
Here's one I've just taken @Xphalnos
image

@ElBread3
Copy link
Contributor

I can definitely provide
screenshot1

@polybiusproxy
Copy link
Collaborator

image

@luevano
Copy link

luevano commented Sep 25, 2024

Can you squeeze in this PR the removal of hardcoded shadps4-emu/shadPS4 github links? I believe you can use relative URLs for the images, that way they're not broken on mirrors (like gitea).

Also, the <a> tag is broken:

shadPS4/README.md

Lines 27 to 33 in f79da98

<p align="center">
<a href="https://shadps4.net/">
<img src="https://github.com/shadps4-emu/shadPS4/blob/main/documents/Screenshots/Sonic Mania.png" width="400">
<img src="https://github.com/shadps4-emu/shadPS4/blob/main/documents/Screenshots/Bloodborne.png" width="400">
<img src="https://github.com/shadps4-emu/shadPS4/blob/main/documents/Screenshots/Undertale.png" width="400">
<img src="https://github.com/shadps4-emu/shadPS4/blob/main/documents/Screenshots/We are DOOMED.png" width="400">
</p>

Github, doesn't care I guess, and renders it just fine; but it bleeds out on gitea for example.

I know these are minor, but seem too simple for a separate PR.

@Xphalnos
Copy link
Contributor Author

Screenshots are updated!

@f1amy
Copy link
Contributor

f1amy commented Sep 26, 2024

This now needs conflicts fixed, sry

@Xphalnos
Copy link
Contributor Author

Forced to close the commit due to this commit.
I reopen one without conflict.

@Xphalnos Xphalnos closed this Sep 27, 2024
@f1amy
Copy link
Contributor

f1amy commented Sep 27, 2024

@Xphalnos sorry, why could you not just rebase?

@Xphalnos
Copy link
Contributor Author

@Xphalnos sorry, why could you not just rebase?

I didn't rebase it because I had other changes to make (#1122)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants