Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTS NEEDED] Separate Updates from Game Folder #1026

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ElBread3
Copy link
Contributor

Up until this point, you either had to keep a duplicate copy of a game (2x space requirements 😵‍) or uninstall and reinstall a game (keeping the pkg around somewhere) in order to play two versions of a game at the same time. I propose we meet in the middle: updates will be extracted to their own folder CUSAXXXXX-UPDATE, and the emulator will read files from this update directory instead of the game folder if present. Additionally, there is a right-click menu to delete the game or the update from the GUI.

I have tested by booting Limbo, but tests for other games are definitely needed as for obvious reasons I haven't tested with Bloodborne. I also haven't tested DLC, as none of my library has any, so DLC will need tested too.

@AselGamer
Copy link

Tested it for 30 mins seems to work fine for bloodborne, my save had DLC items and there was no issue loading them. Only had 1 crash, and it didn't have anything to do with the PR. Sending the report anyway just in case.
shad_log.txt

@ElBread3
Copy link
Contributor Author

Nice! Glad to see there doesn't seem to be any issues! Though I've got two questions, as I'm trying to verify saves version correctly:

  1. Did you make sure that the original game folder is unpatched 1.0 and not a still updated copy?
  2. If you remove the sce_sys folder in the original game folder does making new saves work correctly (and particularly does the param.sfo in the save folder have 1.09 as the version, but that might be too technical for you to answer)?

@Curioso9998
Copy link

Curioso9998 commented Sep 23, 2024

shad_log.zip
I updated the following games but apparently one shows that pace has been updated another is not them the Guilty Gear Xrd -Revelator- CUSA04112 and the ULTRA STREET FIGHTER IV CUSA01846 I say I updated but the behavior of the emulator a the fazelos seems strange to me because it closes and the Guilty Gear Xrd -Revelator does not show the update information but the ULTRA STREET FIGHTER IV even shows but I found it too fast when doing it apparently it didn't update it in fact no

@AselGamer
Copy link

Nice! Glad to see there doesn't seem to be any issues! Though I've got two questions, as I'm trying to verify saves version correctly:

1. Did you make sure that the original game folder is unpatched 1.0 and not a still updated copy?

2. If you remove the sce_sys folder in the original game folder does making new saves work correctly (and particularly does the param.sfo in the save folder have 1.09 as the version, but that might be too technical for you to answer)?
  1. The original game folder appears to be 1.00, but the update is still applied I don't know how s
    ince I removed the separate update folder, I also checked the param.sfo, and it says it's version 1.00. Also, I reinstalled the game without the update and I crash before the title screen, sending log just in case shad_log.txt.
  2. I can't even select the game in the emulator without the sce_sys folder.
    2.1 I just checked the param.sfo in the savedata folder, and it doesn't have the game version, either that or I don't know how to read hexadecimal

I just saw you updating the pr, I hope my testing hasn't been redundant I would have replied earlier, but I was busy

@ElBread3
Copy link
Contributor Author

To clarify why I'm asking, the way the system works is if there is a file in the update directory to load it in there instead of in the original game folder. I'm trying to find any missed place where it could load data from the original game folder instead of the update folder where it should.

The first question was to solve if you have a 1.09 game directory and then a 1.09 update directory. If it loads from the original game directory, which we don't want, I couldn't tell because no matter which it loaded they would both be 1.09.

The second question was to solve if the save system attempted to load from the original game sfo instead of the update sfo, resulting in the save file sfo to be 1.00 (again, don't want this). If there's no sfo in the original game, then if it errors that it can't find it there that's an issue, and if it doesn't error then it finds the sfo in the right place.

TLDR I'm trying to figure out if I need to redirect the save system to the update folder or if it's already good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants