Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix#2047 userrule conflict #2161

Closed
wants to merge 1 commit into from
Closed

fix#2047 userrule conflict #2161

wants to merge 1 commit into from

Conversation

lucksevenl7
Copy link

@lucksevenl7 lucksevenl7 commented Jan 16, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

如果用户在user-rule.txt 里添加了“||ip.cn”,如果gfwList中存在"@@||ip.cn",就将其移除。。

@ghost
Copy link

ghost commented Jan 16, 2019

或许应该先排查一下生成的PAC脚本的问题再考虑对代码动手。

@celeron533
Copy link
Contributor

celeron533 commented Feb 8, 2019

对于一个目标域名:www.foo.com
PAC里有预定义 @@||foo.com
用户定义 ||www.foo.com
如何处理?

可能更好的处理方式是先处理用户定义列表,里面会决定是直连还是代理。如果全都miss,再去查阅标准的预定义代理域名列表

@celeron533 celeron533 changed the title fix#2047 fix#2047 userrule conflict Feb 8, 2019
@celeron533
Copy link
Contributor

#2196

@celeron533 celeron533 closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants