fix: allow fragmentation for inbound UDP replies - #2161
Open
pengwk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outbound_udp_allow_fragmentationoption on inbound UDP listener socketsIP_MTU_DISCOVERProblem
The UDP relay sends encrypted responses back to clients through its inbound listener socket. That socket always enabled DF, even when
outbound_udp_allow_fragmentationwas set. A near-MTU target response can grow after encryption and then fail withEMSGSIZEon the client-facing send path.This change reuses the existing option instead of adding another configuration knob, making it apply to both UDP relay directions.
Verification
cargo test -p shadowsocks --test udp --no-default-features --features aead-cipher-2022(4 passed)cargo check -p shadowsocks-service --no-default-features --features server,aead-cipher-2022