Make genrpm.sh a little safer. #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove function `get_att_val`: That function uses `eval` to set default values for bash variables. Because it is very dangerous to use `eval` (someone call it the plague of shell scripting), I'd like to use the bash builtin to do that. 2. Double quote all variables to avoid unexpected expansion when using it.
|
yeah, EL6 can not use genrpm.sh |
|
Yes, you can submit another pull request to fix the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_att_val:That function uses
evalto set default values for bash variables.Because it is very dangerous to use
eval(someone call it the plague of shell scripting), I'd like to use the bash builtin to do that.BTW, the default version of
giton EL6 is too old to support archive in.tar.gzcommand. Maybe we can change the default format totar?