This repository has been archived by the owner on Apr 9, 2020. It is now read-only.
Add server option to disable logging of client ips #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurkiller
suggested changes
Feb 15, 2018
cmd/shadowsocks-server/server.go
Outdated
| @@ -404,6 +413,7 @@ func main() { | |||
| flag.StringVar(&cmdConfig.Method, "m", "", "encryption method, default: aes-256-cfb") | |||
| flag.IntVar(&core, "core", 0, "maximum number of CPU cores to use, default is determinied by Go runtime") | |||
| flag.BoolVar((*bool)(&debug), "d", false, "print debug message") | |||
| flag.BoolVar((*bool)(&sanitizeIps), "noip-log", false, "suppress client ip addresses in all output") | |||
There was a problem hiding this comment.
noip-log is not a good flag name
There was a problem hiding this comment.
@arthurkiller Which do you prefer?
sanitize-ipsno-ipsprivacy-log
Edit:
or a one letter flag like -P or -x
There was a problem hiding this comment.
I think xxx-xxx is not a good idea. maybe -A means anonymity or -anonymity is better
There was a problem hiding this comment.
after this, you'd better resolve the conflicts locally
There was a problem hiding this comment.
@arthurkiller Ok, I''ll change it to -A.
What would you prefer instead of x.x.x.x:zzzz? The idea is to not change the output too much to make log parsing scripts difficult to write.
|
No idea. Let it go😂
Best regards
✉️✉️✉️✉️✉️✉️✉️✉️✉️✉️✉️✉️✉️✉️
Arthur lee
Sent from my iPhone
… On 17 Feb 2018, at 6:46 PM, Abel Luck ***@***.***> wrote:
@abeluck commented on this pull request.
In cmd/shadowsocks-server/server.go:
> @@ -404,6 +413,7 @@ func main() {
flag.StringVar(&cmdConfig.Method, "m", "", "encryption method, default: aes-256-cfb")
flag.IntVar(&core, "core", 0, "maximum number of CPU cores to use, default is determinied by Go runtime")
flag.BoolVar((*bool)(&debug), "d", false, "print debug message")
+ flag.BoolVar((*bool)(&sanitizeIps), "noip-log", false, "suppress client ip addresses in all output")
@arthurkiller Ok, I''ll change it to -A The idea is to not change the output too much to make log parsing scripts difficult to write.
What would you prefer instead of x.x.x.x:zzzz?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@abeluck Dude will you fix the flag? Or I will close this PR |
|
Sorry about the delay @arthurkiller
|
arthurkiller
approved these changes
Mar 26, 2018
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #265