Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a warning from sslocal logcat output #3166

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

AaronChen0
Copy link
Contributor

@AaronChen0 AaronChen0 commented Aug 28, 2024

When the mode tcp_and_udp is enabled in shadowsocks-android, it will have a sslocal config like this:

{
    "locals": [
        {
            "local_address": "127.0.0.1",
            "local_port": 1080,
	    "mode": "tcp_and_udp"
        }
    ],
    "server": "1.1.1.1",
    "server_port": 12345,
    "password": "xxxxxx",
    "method": "aes-256-gcm"
}

which will output a warning in logcat output, this can be reproduce with sslocal -c config.json -v

WARN main ThreadId(01) shadowsocks_service::local::loadbalancing::ping_balancer: no valid UDP server serving for UDP clients, consider disable UDP with "mode": "tcp_only", currently chose 1.1.1.1:12345

This warning is explained with great detail here.
It causes confusion to users, for example, #3162.

Adding the mode to the global scope dismisses this warning.

@Mygod Mygod merged commit bc01afc into shadowsocks:master Aug 28, 2024
@AaronChen0 AaronChen0 deleted the fix-sslocal-warning branch August 29, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants