Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements #1458

Closed
wongsyrone opened this issue Nov 19, 2017 · 5 comments
Closed

minor improvements #1458

wongsyrone opened this issue Nov 19, 2017 · 5 comments

Comments

@wongsyrone
Copy link
Contributor

Since NDK r16, there are several changes.

  1. switch to c++_static

libc++ is out of beta and is now the preferred STL in the NDK. Starting in r17, libc++ is the default STL for CMake and standalone toolchains. If you manually selected a different STL, we strongly encourage you to move to libc++. For more details, see https://android-developers.googleblog.com/2017/09/introducing-android-native-development.html.

  1. remove all -O? optimization level

Clang now defaults to -Oz instead of -Os. This should reduce generated code size increases compared to GCC.

It means ndk-build already defines the optimization level, no need to override that.

@wongsyrone
Copy link
Contributor Author

Just a hint. It's working well on my side.

@Mygod
Copy link
Contributor

Mygod commented Nov 19, 2017

Clang now defaults to -Oz instead of -Os.

Source?

@wongsyrone
Copy link
Contributor Author

@Mygod
Copy link
Contributor

Mygod commented Nov 19, 2017

These sound good to me.

@madeye What do you think?

@madeye
Copy link
Contributor

madeye commented Nov 19, 2017

Please feel free to submit a pull request for these changes.

madeye added a commit that referenced this issue Nov 28, 2017
minor improvements starting from NDK r16 (#1458)
FakeTrader pushed a commit to FakeTrader/shadowsocks-android that referenced this issue Aug 21, 2018
Signed-off-by: Syrone Wong <wong.syrone@gmail.com>
FakeTrader pushed a commit to FakeTrader/shadowsocks-android that referenced this issue Aug 21, 2018
bannedbook pushed a commit to bannedbook/SpeedUp.VPN that referenced this issue Dec 25, 2019
Signed-off-by: Syrone Wong <wong.syrone@gmail.com>
bannedbook pushed a commit to bannedbook/SpeedUp.VPN that referenced this issue Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants