Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shadowsocks2 -> go-shadowsocks2 #88

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

kazhuravlev
Copy link

After go get program will have name go-shadowsocks2

After `go get` program will have name `go-shadowsocks2`
@riobard
Copy link

riobard commented Jun 28, 2018

Yeah… I'm a little divided by this. The released binaries are all called shadowsocks2, but you're right that if you go get it would keep the repo name…

@mritd
Copy link

mritd commented Dec 17, 2018

Yeah… I'm a little divided by this. The released binaries are all called shadowsocks2, but you're right that if you go get it would keep the repo name…

Should the command in dockerfile also use shadowsocks2?
refs PR #122

@riobard
Copy link

riobard commented Dec 17, 2018

I don't know. Maybe @kazhuravlev is right and it should be called go-shadowsocks2 because shadowsocks2 might be used by the Python implementation if they want to do a major rewrite 😄

@mritd
Copy link

mritd commented Dec 17, 2018

I think the project name can bego-shadowsocks2, but the command name is more convenient to use with shadowsocks. 😂

@riobard
Copy link

riobard commented Dec 17, 2018

@mritd Yes, or maybe all implementations can use the same binary name, just like MariaDB still installs mysql 😂

@riobard riobard merged commit e7d0861 into shadowsocks:master Sep 18, 2019
xiahaijiao pushed a commit to xiahaijiao/go-shadowsocks2 that referenced this pull request Jan 10, 2024
Change shadowsocks2 -> go-shadowsocks2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants