Skip to content

Vino Humano#8

Merged
shadow578 merged 7 commits intomainfrom
effect/vino-humane
Feb 13, 2026
Merged

Vino Humano#8
shadow578 merged 7 commits intomainfrom
effect/vino-humane

Conversation

@shadow578
Copy link
Owner

adds an effect "Vino Humano" that turns killed actors to bottles of wine.

  • ActorWellbeignChange detects actor dead
  • Actor is set invisible & teleported away
  • A wine bottle ("1945 Grand Paladin") is spawned in their place

additional changes:

  • separates repository item spawn logic from loot box class (cherry-picked from Feat/prop rain #1 )
  • fix to ActorwellbeignChange detection logic

Checklist

  • I consent to automatic PR review by GitHub Copilot.
  • I added attributon (if applicable)
  • I updated documentation (if applicable)

@shadow578 shadow578 added the Effect Suggest a new effect for the mod label Feb 13, 2026
@shadow578 shadow578 requested a review from Copilot February 13, 2026 16:39
@shadow578 shadow578 marked this pull request as ready for review February 13, 2026 16:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “Vino Humano” chaos effect that replaces killed actors with a spawned wine bottle, while refactoring repository-item spawning into a reusable base class and improving actor death vs pacified detection.

Changes:

  • Introduces ZSpawnRepositoryItemEffectBase to centralize repository prop loading and spawning.
  • Refactors ZSpawnRandomItemEffect (“Loot Box”) to use the new repository spawn base.
  • Adds ZActorToWineEffect and updates wellbeing state tracking to distinguish killed vs pacified.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/Effects/Player/ZSpawnRandomItemEffect.h Switches Loot Box effect to inherit repository-item spawn base.
src/Effects/Player/ZSpawnRandomItemEffect.cpp Uses shared repository-prop list and base spawn helper.
src/Effects/Base/ZSpawnRepositoryItemEffectBase.h New base API for loading/selecting/spawning repository items.
src/Effects/Base/ZSpawnRepositoryItemEffectBase.cpp Implements repository parsing and item spawning via template spawners.
src/Effects/Base/ZActorWellbeingChangeEffectBase.h Adds explicit actor state model + GetActorState() helper.
src/Effects/Base/ZActorWellbeingChangeEffectBase.cpp Uses GetActorState() to distinguish dead vs pacified.
src/Effects/Actors/ZActorToWineEffect.h Declares new actor-to-wine effect combining wellbeing + spawn bases.
src/Effects/Actors/ZActorToWineEffect.cpp Implements “turn killed actors into a wine bottle” behavior and registers effect.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shadow578 shadow578 merged commit 415eb3a into main Feb 13, 2026
@shadow578 shadow578 deleted the effect/vino-humane branch February 13, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Effect Suggest a new effect for the mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant