Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/: sget*ent(): Simplify by calling strdup(3) #1146

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alejandro-colomar
Copy link
Collaborator

@alejandro-colomar alejandro-colomar commented Dec 7, 2024

While at it, rename the function parameter.

v1b
  • Rebase
$ git range-diff alx/master..gh/strdup_ master..strdup_ 
1:  9b9ee9c8 = 1:  e2169576 lib/: Simplify by calling strdup(3)
2:  b81ed41a = 2:  0d41e7a6 lib/: Remove arbitrary limitation by calling strdup(3)
3:  aab18a17 = 3:  77cf47bb lib/: Rename local variable
4:  a4efdf54 = 4:  0eff731b lib/sgetpwent.c: sgetpwent(): Trim the trailing '\n'
v1c
  • Rebase
$ git range-diff alx/master..gh/strdup_ master..strdup_ 
1:  e2169576 = 1:  39ab645a lib/: Simplify by calling strdup(3)
2:  0d41e7a6 = 2:  698435c5 lib/: Remove arbitrary limitation by calling strdup(3)
3:  77cf47bb = 3:  4f54e215 lib/: Rename local variable
4:  0eff731b = 4:  410ba3fb lib/sgetpwent.c: sgetpwent(): Trim the trailing '\n'
v1d
  • Rebase
$ git range-diff master..gh/strdup_ shadow/master..strdup_ 
1:  39ab645a = 1:  16793a90 lib/: Simplify by calling strdup(3)
2:  698435c5 = 2:  171d9908 lib/: Remove arbitrary limitation by calling strdup(3)
3:  4f54e215 = 3:  bfc747a8 lib/: Rename local variable
4:  410ba3fb = 4:  d9c502a6 lib/sgetpwent.c: sgetpwent(): Trim the trailing '\n'
v1e
  • Rebase
$ git range-diff master..gh/strdup_ shadow/master..strdup_ 
1:  16793a90 = 1:  9978c231 lib/: Simplify by calling strdup(3)
2:  171d9908 = 2:  61bf4c55 lib/: Remove arbitrary limitation by calling strdup(3)
3:  bfc747a8 = 3:  ada9c214 lib/: Rename local variable
4:  d9c502a6 = 4:  cb73a7f4 lib/sgetpwent.c: sgetpwent(): Trim the trailing '\n'

@alejandro-colomar alejandro-colomar force-pushed the strdup_ branch 4 times, most recently from 64c62b1 to b3cf85c Compare December 7, 2024 21:11
@alejandro-colomar alejandro-colomar changed the title lib/sgetgrent.c: sgetgrent(): Simplify by calling strdup(3) lib/: sget*ent(): Simplify by calling strdup(3) Dec 7, 2024
@alejandro-colomar alejandro-colomar mentioned this pull request Dec 9, 2024
@alejandro-colomar alejandro-colomar marked this pull request as ready for review December 22, 2024 12:05
@alejandro-colomar alejandro-colomar force-pushed the strdup_ branch 2 times, most recently from 410ba3f to d9c502a Compare January 24, 2025 14:57
While at it, rename the function parameter.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
This makes these APIs more consistent with the ones for groups,
which strdup(3) memory as necessary.

It also makes the code simpler.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
Call it 'dup', which reminds that it's a strdup(3)d string.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
Just like the other sget*ent() functions do.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant