Fix example app triangle on macOS #8889
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change colorTarget format to Format::RGBA8Unorm. Also rename vertex format const from format to vertexFormat for clarity.
tangent-vector
approved these changes
Nov 3, 2025
Merged
via the queue into
shader-slang:master
with commit Nov 3, 2025
4755029
37 of 38 checks passed
jvepsalainen-nv
added a commit
to jvepsalainen-nv/slang
that referenced
this pull request
Nov 4, 2025
Change `colorTarget` format to `Format::RGBA8Unorm` to fix example app `triangle` on macOS. Also rename vertex format const from `format` to `vertexFormat` for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
colorTargetformat toFormat::RGBA8Unormto fix example apptriangleon macOS.Also rename vertex format const from
formattovertexFormatfor clarity.