fix(sidebar): smooth inset collapsed margin with 200ms linear transition#9661
Open
mohit4bug wants to merge 3 commits intoshadcn-ui:mainfrom
Open
fix(sidebar): smooth inset collapsed margin with 200ms linear transition#9661mohit4bug wants to merge 3 commits intoshadcn-ui:mainfrom
mohit4bug wants to merge 3 commits intoshadcn-ui:mainfrom
Conversation
Contributor
|
@mohit4bug is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In inset sidebar mode, collapsing/expanding caused a visible content jump.
The sidebar width was animating, but the inset margin state change felt abrupt, creating a brief backward flicker.
Fix
Applied a margin transition to inset spacing so content movement stays in sync with sidebar motion:
transition-[margin]duration-200ease-linearThis keeps behavior unchanged while smoothing the visual transition.
Before
Inset content snaps/jumps when the sidebar collapses, causing a noticeable backward flicker.
before.mov
After
Inset content transitions smoothly with sidebar collapse/expand, with no snap or flicker.
after.mov