fix(resizable): upgrade to react-resizable-panels v4 #9461
+2,869
−268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update component API: PanelGroup → Group, PanelResizeHandle → Separator - Update prop: direction → orientation - Update size values: number → string with units (e.g., "50%") - Update CSS selectors: data-[panel-group-direction] → aria-[orientation] - Update controlled component: onLayout → onLayoutChange with Layout type Closes shadcn-ui#9118, shadcn-ui#9136, shadcn-ui#9200
Contributor
|
@jaem0629 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
2 tasks
Collaborator
|
Is this a duplicate of #9433? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9118, #9136, #9200
react-resizable-panelsv4 renamed exports and changed APIs, so CLI users were getting build errors like:Picking up from #9124 (bvaughn's PR). He couldn't continue due to lint/test issues on main, so I applied his changes with the CSS selector fix that stevezhu pointed out in the review.
What changed
PanelGroup→Group,PanelResizeHandle→Separatordirection→orientationdefaultSize={50}→defaultSize="50%"data-[panel-group-direction=vertical]→aria-[orientation=horizontal]for Separator (flipped)onLayout→onLayoutChangewithLayouttypeTesting
pnpm lint(passed)pnpm test- 2 failures ininit.test.ts, unrelated (pre-existingbuttonVariantsissue)