fix: Pass template into buildInitUrl #9382
Open
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --preset option without a URL would previously fail as the generated URL would not include the template query string param. Example: ``` ~/Code ➜ pnpm dlx shadcn@latest create --preset radix-nova ✔ What is your project named? … my-app ✔ Which template would you like to use? › Next.js Something went wrong. Please check the error below for more details. If the problem persists, please open an issue on GitHub. Message: Failed to fetch from registry (400): https://ui.shadcn.com/init?base=radix&style=nova&baseColor=neutral&theme=neutral&iconLibrary=hugeicons&font=inter&menuAccent=subtle&menuColor=default&radius=default Suggestion: There was a client error. Check your request parameters. ``` This fixes this issue by passing along the template so that a proper URL is generated. In the example above the proper URL is: https://ui.shadcn.com/init?base=radix&style=nova&baseColor=neutral&theme=neutral&iconLibrary=hugeicons&font=inter&menuAccent=subtle&menuColor=default&radius=default&template=next Co-authored-by: Erin Galarza <eringalarza@gmail.com>
Contributor
|
@dgalarza is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
shadcn
added
the
area: roadmap
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where using the --preset option without a URL would fail with a 400 error because the generated URL was missing the required template query parameter.
Changes:
- Modified
buildInitUrlfunction to accept atemplateparameter - Updated the call to
buildInitUrlto pass the selected template
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --preset option without a URL would previously fail as the generated URL would not include the template query string param.
Example:
This fixes this issue by passing along the template so that a proper URL is generated. In the example above the proper URL is:
https://ui.shadcn.com/init?base=radix&style=nova&baseColor=neutral&theme=neutral&iconLibrary=hugeicons&font=inter&menuAccent=subtle&menuColor=default&radius=default&template=next