Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www sidebar-nav): refine hover and disabled styles for nav item tags #5821

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jacksonmills
Copy link
Contributor

@Jacksonmills Jacksonmills commented Nov 13, 2024

Streamlined class assignments for improved consistency and maintainability. Hover effects now underline only titles with a span, excluding tags like "New" to avoid unwanted styling. Disabled elements have a unified appearance for better visual clarity, aligned with accessibility standards. These adjustments reduce CSS complexity and enhance styling accuracy.

🚧 examples using red bg to show off bug

example showing the bug:
image

fixed example and also disabled with no underlines:
image
image

Streamlined class assignments for improved consistency and maintainability. Hover effects now underline only titles with a span, excluding tags like "New" to avoid unwanted styling. Disabled elements have a unified appearance for better visual clarity, aligned with accessibility standards. These adjustments reduce CSS complexity and enhance styling accuracy.
Copy link

vercel bot commented Nov 13, 2024

@Jacksonmills is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant