Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(523): update accordion chevron to be hidden from assistive tech #524

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

garyb1
Copy link

@garyb1 garyb1 commented Jun 1, 2023

Closes #523

Set aria-hidden="true" to hide the icon. I set focusable=false if you need to support IE11, otherwise they'll appear in the tab order and some issues with JAWS can be introduced.

@vercel
Copy link

vercel bot commented Jun 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) Jun 1, 2023 8:09pm

@vercel
Copy link

vercel bot commented Jun 1, 2023

@garyb1 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@garyb1 garyb1 force-pushed the 523-accordion-svg branch from 9799add to 0982b7c Compare June 1, 2023 20:07
@garyb1 garyb1 force-pushed the 523-accordion-svg branch from 0982b7c to 80334d3 Compare June 1, 2023 20:09
@garyb1
Copy link
Author

garyb1 commented Dec 8, 2023

@jocarrd I ran pnpm build:registry and changes to toast.json were made. Is this ok do you know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARIA hide the accordion chevron SVG
2 participants