Fix false "discarded non-Unit value" errors on @react classes #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macro-generated class body emitted calls to `bump`, which accepted => Unit Since last expression of that call was `null.asInstanceOf[Snapshot]`, Scala would auto-discard that value, and emit a warning if user has -Ywarn-value-discard. That means a false positive warning for each @react class. Explicitly returning () in the block fixes that for scalac lint.
|
Done |
|
Awesome, thanks so much again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macro-generated class body emitted calls to
bump, which accepted=> Unit.Since last expression of that call was
null.asInstanceOf[Snapshot], Scala would auto-discard that value, and emit a warning if user has -Ywarn-value-discard. That means a false positive warning for each @react class.Explicitly returning () in the block fixes that for scalac lint.