-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use awesomplete as autocomplete lib and remove jQuery - shaarli/Shaarli#148 #165
Conversation
Congrats @ArthurHoaro great work! 2 small problems I noticed while testing:
What do you think? Can you fix this? Except these 2 points, everything is fine and
🤘 |
I think the next step after merging this would be #49 (re-adding autocompletion to the "Filter by tag" field on the main page |
Another possible improvement is to use Currently it's only the |
Thanks !
It's hardly transparent on my screen, but I guess I can remove this effect.
You're right. I'll do this. About your other improvements, I suggest you mention them on #148. |
* Add awesomplete dependancy (source + min + CSS) * Remove jQuery and jQuery-UI dependancy * Few CSS ajustements * Use tags complete list as RainTPL var (and display it as HTML) * Remove "disable jQuery" feature * Remove tag list web service
ccfdbb8
to
bdd1715
Compare
Done and rebased. |
Great, testing this right now, I'll merge it on Sunday, March 15 if it works as expected and no one disagrees. Hats off |
EDIT : And update COPYING.
EDIT2:
😆