Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use awesomplete as autocomplete lib and remove jQuery - shaarli/Shaarli#148 #165

Merged
merged 1 commit into from
Mar 15, 2015

Conversation

ArthurHoaro
Copy link
Member

  • Add awesomplete dependancy (source + min + CSS)
  • Remove jQuery and jQuery-UI dependancy
  • Few CSS ajustements
  • Use tags complete list as RainTPL var (and display it as HTML)
  • Remove "disable jQuery" feature
  • Remove tag list web service

EDIT : And update COPYING.

EDIT2:
snapshot2 😆

@nodiscc
Copy link
Member

nodiscc commented Mar 12, 2015

Congrats @ArthurHoaro great work!

2 small problems I noticed while testing:

  • The autocompletion dropdown/list background should probably not be transparent (to stay coherent with the general style)
  • Autocompletion should probably start when entering the first character (currently it only starts after 2)

What do you think? Can you fix this? Except these 2 points, everything is fine and

563 additions and 27,028 deletions

🤘

@nodiscc
Copy link
Member

nodiscc commented Mar 12, 2015

I think the next step after merging this would be #49 (re-adding autocompletion to the "Filter by tag" field on the main page

@nodiscc
Copy link
Member

nodiscc commented Mar 12, 2015

Another possible improvement is to use Tab or Left Arrow keys to add the selected suggestion to the contents of the field.

Currently it's only the Enter key and can cause mistakenly triggering "Save" when you're not finished editing tags and hit enter when the suggestion doesn't have focus.

@ArthurHoaro
Copy link
Member Author

Thanks !

The autocompletion dropdown/list background should probably not be transparent (to stay coherent with the general style)

It's hardly transparent on my screen, but I guess I can remove this effect.

Autocompletion should probably start when entering the first character (currently it only starts after 2)

You're right. I'll do this.

About your other improvements, I suggest you mention them on #148.

  * Add awesomplete dependancy (source + min + CSS)
  * Remove jQuery and jQuery-UI dependancy
  * Few CSS ajustements
  * Use tags complete list as RainTPL var (and display it as HTML)
  * Remove "disable jQuery" feature
  * Remove tag list web service
@ArthurHoaro
Copy link
Member Author

Done and rebased.

@nodiscc
Copy link
Member

nodiscc commented Mar 12, 2015

Great, testing this right now, I'll merge it on Sunday, March 15 if it works as expected and no one disagrees.

Hats off

@nodiscc nodiscc modified the milestone: 0.0.44beta Mar 13, 2015
@nodiscc nodiscc merged commit bdd1715 into shaarli:master Mar 15, 2015
@ArthurHoaro ArthurHoaro deleted the autocomplete branch September 2, 2015 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup and refactoring enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants